Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docstring examples to glance.py [2015.5] #33486

Merged
merged 3 commits into from
May 25, 2016

Conversation

justinta
Copy link

@justinta justinta commented May 24, 2016

What does this PR do?

Fixes docstring issues that saltstack/salt-ci-images#175 exposes. Dependencies get installed that previously weren't, which loads this module.

The swift.head function does not have a body, so I've skipped it from being checked for a docstring.

@gtmanfred Can you make sure these example look correct?

What issues does this PR fix or reference?

references saltstack/salt-ci-images#175

Tests written?

No

@justinta justinta changed the title 2015.5 Add docstring examples to glance.py [2015.5] May 24, 2016
@gtmanfred
Copy link
Contributor

looks good to me

@rallytime
Copy link
Contributor

@jtand Same question here. It looks like there's an additional commit included.

@rallytime rallytime added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label May 25, 2016
@justinta
Copy link
Author

@rallytime Same update here.

@cachedout cachedout merged commit 6f7fda0 into saltstack:2015.5 May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants