Fix #33578 disks grain #33604
Merged
Fix #33578 disks grain #33604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go Go Jenkins! |
cachedout
pushed a commit
that referenced
this pull request
Jun 7, 2016
Fix #33604 implementation when 'geom disk list' does not output rotat…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some fixes for the disks grain changes in 2016.3.0.
What issues does this PR fix or reference?
#33578
Previous Behavior
The disks grain would throw a ValueError exception if
rotationratereturned(unknown)ingeom disk listbecause it tries to cast the data to an integer.The grain would include cd-rom drives.
New Behavior
The datatype parsing is more resilient and will return None if the expected data type is not present.
The grain will not include cd-roms.
Tests written?
No