Fix win servermanager #33654
Merged
Fix win servermanager #33654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@twangboy Is this still a WIP or is it ready to go? |
|
@cachedout Still fixing tests, haven't had a chance to get to it yet... working on it now. |
|
@cachedout Maybe just a rebase |
twangboy
force-pushed
the
fix_win_servermanager
branch
from
ae2de6d
to
6c7b216
Compare
|
@cachedout Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds additional parameters to the win_servermanager module and state
What issues does this PR fix or reference?
#32827
Previous Behavior
Could not select a source when trying to install a role whose payload had been removed from the system. Could not remove a features payload.
New Behavior
Pass a path to the source using the source parameter. Have the system restart if needed by setting restart to True. Remove payload by setting remove_payload to True.
Tests written?
NA