Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional functionality to win_dism.py #33771

Merged
merged 19 commits into from
Jun 8, 2016
Merged

Conversation

twangboy
Copy link
Contributor

@twangboy twangboy commented Jun 4, 2016

What does this PR do?

Adds missing features to win_dism. Ability to manage packages on non-server versions of windows

What issues does this PR fix or reference?

https://github.com/saltstack/zh/issues/740
#27371
https://github.com/saltstack/zh/issues/754

Tests written?

Yes

@cachedout
Copy link
Contributor

Hi @twangboy

Looks like this caused a number of test failures as well as needing some lint fixed up, please.

@cachedout cachedout added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Jun 6, 2016
@twangboy twangboy closed this Jun 6, 2016
@twangboy twangboy reopened this Jun 7, 2016
@twangboy twangboy closed this Jun 7, 2016
@twangboy twangboy reopened this Jun 7, 2016
@twangboy twangboy changed the title [WIP] Additional functionality to win_dism.py Additional functionality to win_dism.py Jun 7, 2016
@cachedout cachedout merged commit 01aaf3e into saltstack:2016.3 Jun 8, 2016
@twangboy twangboy deleted the win_dism branch August 30, 2016 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants