Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_servermanager execution module doesn't work on Server Core installations of Windows Server 2008/Windows Server 2008 R2 or on Windows client-based operating systems (Vista/7/8/8.1/etc.) #27371

Closed
xenophonf opened this issue Sep 24, 2015 · 6 comments
Assignees
Labels
Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps Windows
Milestone

Comments

@xenophonf
Copy link
Contributor

The implementation of the salt.modules.win_servermanager execution module has the following dependencies:

  • Powershell, which is missing on Server Core installations of Windows Server 2008 and Windows Server 2008 R2
  • the ServerManager PS module, which cannot target Windows client-based operating systems

These limit the usefulness of win_servermanager to Standard installations of Windows Server 2008 and Windows Server 2008 R2 and to Windows Server 2012 and newer.

I want to propose an alternate method for managing feature installations (and, potentially, other Windows image servicing operations) that uses DISM instead of the ServerManager PS module. You can find the proof of concept here: execution module, state module. I would be happy to contribute these to Salt via a pull request, but I'd like some feedback as to how best to integrate them with the current code base.

@jfindlay jfindlay added Feature new functionality including changes to functionality and code refactors, etc. Windows Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Sep 24, 2015
@jfindlay jfindlay added this to the Approved milestone Sep 24, 2015
@jfindlay
Copy link
Contributor

@xenophonf, thanks for your work on this.

@twangboy, @UtahDave

@xenophonf
Copy link
Contributor Author

Just to follow up: I'm going to clean up my PoC and submit it in a future pull request.

@UtahDave
Copy link
Contributor

Awesome, thanks, @xenophonf !

@twangboy
Copy link
Contributor

twangboy commented May 6, 2016

For what it's worth, The ServerManager module is not available on Windows Server 2008 at all. It is only available on Windows Server 2008R2 and later.

@twangboy
Copy link
Contributor

twangboy commented Jun 2, 2016

There's already a win_dism module. #30729

@twangboy
Copy link
Contributor

twangboy commented Jun 7, 2016

Added additional functions to the module and state.

@twangboy twangboy closed this as completed Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps Windows
Projects
None yet
Development

No branches or pull requests

4 participants