removes bad logic in wait_for_default_password #33940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking for "!" in the password results in nodes not being bootstrapped
remove bad logic in wait_for_default_password
|
@techhat Looks like you wrote this originally. Could you have a look please? |
cachedout
added
the
Pending-Discussion
|
For what its worth Vultr support confirmed to me in a recent discussion that their password scheme recently changed which may be why this issue just surfaced now. |
|
I can confirm a similar fix works for me. One disturbing thing is that the password changes during the deployment, so I see why this was originally added even if it's not exactly true any longer. I added support for ssh keys (similar to the DigitalOcean driver) to try to get around this quirk. |
|
@iggy do you have a PR for your ssh changes? |
|
I'm working on it... This is what I have so far. https://gist.github.com/iggy/8389725d25db437b521caf1aa2585b73 |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Jun 16, 2016
* upstream/develop: removed method that doesn't exist (saltstack#34026) Fix wheel integration test (saltstack#34040) Updated latest version for doc site remove bad logic in wait_for_default_password (saltstack#33940) Removed `!`-password check (saltstack#33939) Added check for presence of Testinfra library (saltstack#34015) Always make changes to minion config if set (saltstack#34022) expose environment specific information stored in consul (saltstack#34027) Whitespace fix for develop (saltstack#34016) Raise a warning to a user if using Py2 byte-compiled files in Py3 (saltstack#34006) Fix hashlib module for python 3 (saltstack#34007)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
removes bad logic in wait_for_default_password
What issues does this PR fix or reference?
checking for "!" in the password results in nodes not being bootstrapped if the don't have a "!" in the password string.