Save an entire minion cache traversal on each master pub #33948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2016 15:43
We were doing an extra and unecessary full traversal of the minion cache. This refactors all returners and the master to reduce this to a single call. More work will be forthcoming to reduce this even further, especially in the context of auth lookups.
thatch45
added
the
bugfix-bckport
|
Need on 2015.8 |
This was referenced Jun 14, 2016
rallytime
added
ZZZ[Done]-back-ported-bf
thatch45
added a commit
that referenced
this pull request
Jun 16, 2016
Back-port #33948 to 2016.3 + add log message
sjmh
pushed a commit
to sjmh/salt
that referenced
this pull request
Sep 8, 2016
With a large amount of minions and large ACL sets, check_minions starts to become rather expensive. The master's publish was already obtaining this list ( albeit later in execution ), but by moving it up and passing it to CkMinion's auth_check, it allows CkMinion's validate_tgt to skip a cache traversal. Related to saltstack#33948
cachedout
pushed a commit
that referenced
this pull request
Sep 17, 2016
With a large amount of minions and large ACL sets, check_minions starts to become rather expensive. The master's publish was already obtaining this list ( albeit later in execution ), but by moving it up and passing it to CkMinion's auth_check, it allows CkMinion's validate_tgt to skip a cache traversal. Related to #33948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing an extra and unecessary full traversal of the minion
cache. This refactors all returners and the master to reduce this
to a single call. More work will be forthcoming to reduce this even
further, especially in the context of auth lookups.