Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save an entire minion cache traversal on each master pub #33948

Merged
merged 2 commits into from
Jun 13, 2016

Conversation

cachedout
Copy link
Contributor

We were doing an extra and unecessary full traversal of the minion
cache. This refactors all returners and the master to reduce this
to a single call. More work will be forthcoming to reduce this even
further, especially in the context of auth lookups.

Mike Place added 2 commits June 10, 2016 15:43
We were doing an extra and unecessary full traversal of the minion
cache. This refactors all returners and the master to reduce this
to a single call. More work will be forthcoming to reduce this even
further, especially in the context of auth lookups.
@thatch45 thatch45 merged commit a9c304c into saltstack:develop Jun 13, 2016
@rickh563 rickh563 added the ZD The issue is related to a Zendesk customer support ticket. label Jun 14, 2016
@thatch45 thatch45 added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Jun 14, 2016
@meggiebot
Copy link

Need on 2015.8

@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Jun 14, 2016
thatch45 added a commit that referenced this pull request Jun 16, 2016
thatch45 added a commit that referenced this pull request Jun 16, 2016
Back-port #33948 to 2016.3 + add log message
sjmh pushed a commit to sjmh/salt that referenced this pull request Sep 8, 2016
With a large amount of minions and large ACL sets, check_minions starts
to become rather expensive.  The master's publish was already obtaining
this list ( albeit later in execution ), but by moving it up and passing
it to CkMinion's auth_check, it allows CkMinion's validate_tgt to skip a
cache traversal. Related to saltstack#33948
cachedout pushed a commit that referenced this pull request Sep 17, 2016
With a large amount of minions and large ACL sets, check_minions starts
to become rather expensive.  The master's publish was already obtaining
this list ( albeit later in execution ), but by moving it up and passing
it to CkMinion's auth_check, it allows CkMinion's validate_tgt to skip a
cache traversal. Related to #33948
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awesome ZD The issue is related to a Zendesk customer support ticket. ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants