Back-port #33948 to 2016.3 + add log message #34009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were doing an extra and unecessary full traversal of the minion cache. This refactors all returners and the master to reduce this to a single call. More work will be forthcoming to reduce this even further, especially in the context of auth lookups.
rallytime
added
the
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Back-ports #33948 to the 2016.3 branch. This also adds some logic to detect if a returner does not have the
minionskwarg present in it'ssave_loadfunction, which can happen when users are using custom returners.Instead of updating the release notes for Carbon as in the original PR, this adds a note to the 2016.3.2 release notes.
A separate PR for 2015.8 backport will follow.
ping @thatch45 and @cachedout