Make module.ssh.recv_known_host() more resilient against hosts not returning a key
#34197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…returning a key Some providers (esp. Bitbucket) have faulty git/SSH endpoints which often simply return empty results. A previous attempt in Salt to improve this by adding an optional timeout value didn't change much here, as it just increased the time it took to return: nothing. Repeating the request a few times until the host returns a value works around this issue far more reliable. Signed-off-by: Elias Probst <mail@eliasprobst.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some providers (esp. Bitbucket) have faulty git/SSH endpoints which
often simply return empty results. A previous attempt in Salt to improve
this by adding an optional timeout value didn't change much here, as it
just increased the time it took to return: nothing.
Repeating the request a few times until the host returns a value works
around this issue far more reliable.
Signed-off-by: Elias Probst mail@eliasprobst.eu