Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make module.ssh.recv_known_host() more resilient against hosts not returning a key #34197

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Make module.ssh.recv_known_host() more resilient against hosts not returning a key #34197

merged 1 commit into from
Jun 22, 2016

Commits on Jun 22, 2016

  1. Make module.ssh.recv_known_host() more resilient against hosts not … 

    …returning a key

Some providers (esp. Bitbucket) have faulty git/SSH endpoints which
often simply return empty results. A previous attempt in Salt to improve
this by adding an optional timeout value didn't change much here, as it
just increased the time it took to return: nothing.

Repeating the request a few times until the host returns a value works
around this issue far more reliable.

Signed-off-by: Elias Probst <mail@eliasprobst.eu>
    @eliasp
    eliasp committed Jun 22, 2016
    Configuration menu
    Copy the full SHA
    82c4b12 View commit details
    Browse the repository at this point in the history