GCE Cloud tests #34871
GCE Cloud tests #34871
Conversation
|
CC @cachedout @rallytime |
|
@tonybaloney This doesn't look quite right. :) The only changes appear to be merge conflict lines. As to why the test suite didn't uncover that issue, it is because the cloud integration tests (since they spin up a bunch of VMs for each cloud provider) are only run on two distributions currently: CentOS 7 and Ubuntu 14. I bet I can convince @jtand to add SUSE to that mix though. |
|
@tonybaloney Oh, I must have been looking at an old reference before. Thanks for taking another crack at this. Can you take a look at the small pylint error, as well as the related test failure when you get a chance? |
cachedout
added
the
Pending-Discussion
|
done and done @rallytime |
|
@tonybaloney Looks like some merge conflicts. Could you rebase this please? |
|
rebased. |
|
Awesome! thanks @tonybaloney - Looks like Jenkins is having a rough time in general on our end. I'll trigger a new test run. |
|
Go Go Jenkins! |
1 similar comment
|
Go Go Jenkins! |
|
Thanks for cleaning these up @tonybaloney - this looks great. |
* upstream/develop: (153 commits) Increase all run_script timeouts to 30s (saltstack#34956) Fix grains integration tests for Windows (saltstack#34941) GCE Cloud tests (saltstack#34871) Create regdata before try/except (saltstack#34931) Add prune option to reg.list (saltstack#34934) Skip inode test in Windows (saltstack#34938) Remove use_carrier bond for Ubuntu Xenial later (saltstack#34779) Add jid to salt.function orchestration events [bashcompletion] replace ticks with bash subshell [bashcompletion] ignore salt-key headers Add jid to orchestration returns Avoid UnboundLocalError in beacons module [bash-completion] hide timeout in salt-output Master performance improvement (saltstack#34916) Update service_rh provider to exclude XenServer >= 7. (saltstack#34915) Lint fixes for saltstack#34923 pv_present should execute pvcreate with -y if existing filesystem signature detected Handle exception when no Slack API key was provided zone absent with tests added zone_present state check ...
What does this PR do?
Strip out all the mocks and just focus on the certificate and import process for the GCE cloud module. The test suite needs expanding, the GCE cloud module has a ton of untested behaviours, dict mappings and all sorts of assumptions about environment and configuration that are not tested.
Change also updates all the of the temporary fixes around certificates for SuSE and MacOS/brew/ports. Libcloud 1.0 + supports
certifias the source of SSL/PEM files.What issues does this PR fix or reference?
Issue #34852
Previous Behavior
GCE tests would hang trying to instantiate driver, GCE changed the token logic in a recent version of libcloud.
New Behavior
Remove this section if not relevant
Tests written?
Yes/No
Please review Salt's Contributing Guide for best practices.