Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create regdata before try/except #34931

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Create regdata before try/except #34931

merged 1 commit into from
Jul 26, 2016

Conversation

techhat
Copy link
Contributor

@techhat techhat commented Jul 25, 2016 •
edited by meggiebot
Loading

Previous Behavior

[CRITICAL] Engine <salt.loader.LazyLoader object at 0x7f6a72baf610> could not be started! Error: local variable 'regdata' referenced before assignment
[INFO    ] Process <class 'salt.engines.Engine'> (18594) died with exit status None, restarting...

Tests written?

No.

@rallytime
Copy link
Contributor

Go Go Jenkins!

@rallytime rallytime merged commit cdc9882 into saltstack:develop Jul 26, 2016
@techhat techhat deleted the regdata branch July 26, 2016 18:14
gitebra pushed a commit to gitebra/salt that referenced this pull request Jul 26, 2016
@jojohans
Merge remote-tracking branch 'upstream/develop' into develop
4a1dd11 
* upstream/develop: (153 commits)
  Increase all run_script timeouts to 30s (saltstack#34956)
  Fix grains integration tests for Windows (saltstack#34941)
  GCE Cloud tests (saltstack#34871)
  Create regdata before try/except (saltstack#34931)
  Add prune option to reg.list (saltstack#34934)
  Skip inode test in Windows (saltstack#34938)
  Remove use_carrier bond for Ubuntu Xenial later (saltstack#34779)
  Add jid to salt.function orchestration events
  [bashcompletion] replace ticks with bash subshell
  [bashcompletion] ignore salt-key headers
  Add jid to orchestration returns
  Avoid UnboundLocalError in beacons module
  [bash-completion] hide timeout in salt-output
  Master performance improvement (saltstack#34916)
  Update service_rh provider to exclude XenServer >= 7. (saltstack#34915)
  Lint fixes for saltstack#34923
  pv_present should execute pvcreate with -y if existing filesystem signature detected
  Handle exception when no Slack API key was provided
  zone absent with tests
  added zone_present state check
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@techhat @rallytime