Avoid UnboundLocalError in beacons module #34935
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If something goes wrong with the event response call, we'll hit an
UnboundLocalError
stack trace during theif beacons
check below. This avoids that stacktrace by instantiatingbeacons
asNone
before trying the event call.This imports the correct salt.utils.event lib (not just salt.utils - event.py is it's own file and there isn't an event reference in
salt.utils.__init__.py
).What issues does this PR fix or reference?
None that I know of - found during the testing of the
Previous Behavior
When trying to perform a
salt-call --local beacons.list
function, the stacktrace happens when no beacons are configured:New Behavior
No more stacktrace:
Tests written?
No - there are already integration tests covering this feature in general. That's how this bug was found. Those tests started failing during the merge-forward in #34894.