Resolve a couple bugs in orchestration output #35290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some test failures and some lint fixes here please. |
cachedout
added
the
Pending-Discussion
This allows the printing of namespaced events to be suppressed, for instance in cases where we are running orchestration and don't want the return data from a runner/wheel function to be printed to the console.
This gets passed through to the highstate outputter to suppress the error in the output when the changes param is not a dict.
terminalmage
force-pushed
the
issue35051
branch
from
167e1a5
to
d621aa7
Compare
|
OK, just pushed fixes, tests should be green when they complete. |
I do not see the |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request suppresses printing of the ret event for runners executed from within orchestration, preventing the output from being displayed twice.
Additionally, for orchestration runner/wheel jobs, when the return data is not a dictionary, an error shows in the
Changessection of the return data. This pull request also modifies the highstate outputter to look for a__orchestration__key in the return data, and if it is present and set toTrue, the data in thechangesvalue will simply be displayed using the nested outputter, bypassing the error message in the displayed output.Resolves #35051.