fix 35165, salt-run jobs.exit_success jid is broken #35331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #35165
For more details about the issue, please check the issue url.
A little bit more details about the fix:
It is calling
list_job
rather thanlookup_jid
becauselookup_jid
only returns successful'Result'
of returned minions whereaslist_job
returns more info which include failed minions as well.From the load perspective, calling
list_job
is same as callinglookup_jid
becauselookup_jid
just callslist_job
and trim the'Result'
.exit_success
will returnTrue
for minions that have successful returns andFalse
for those that don't have returns or defunct returns.retcode
is not able to be used in determining job success because all of the job management and execution codes do not haveretcode
as a field. Feel free to correct me if I am wrongWhat issues does this PR fix or reference?
Previous Behavior
Check the issue for more details.
In short,
salt-run jobs.exit_success jid
is brokenNew Behavior
Tests written?
No
Please review Salt's Contributing Guide for best practices.