Fixes consul.agent_service_register which was broken for registering #35419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bugs that won't register service checks when registering a service. It also makes it so that salt states that register services and service checks can adhere to the consul.io documentation.
What issues does this PR fix or reference?
??
Tests written?
No. Testing will require a test fixture comprised of at least 4 machine instances, 3 for the consul server cluster and at lease one consul client. There probably needs to be a plan to test the consul module with the test fixture.
Please review Salt's Contributing Guide for best practices.