[dockerng] RepoTags can be also be None with docker 1.12 #35447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ticosax
changed the title
|
I got tricked by github |
Add support for this new value.
ticosax
force-pushed
the
RepoTags-null-docker-1.12
branch
from
41f6597
to
b833b5f
Compare
|
Thanks @ticosax |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Aug 16, 2016
* upstream/develop: (26 commits) Use BytesIO from six for gzip operations (saltstack#35484) Return cleaner error on pillar/grains rendering failure (saltstack#35437) LXC execution module Carbon deprecations Add soem more notes to the salt-cp doc call to boto_secgroup.convert_to_group_ids should be by keyword args, the earlier code would end up with incorrect parameters being used with region being mapped to vpc_name. Fix orderering in test_add_rule Fix failing win_firewall_tests [develop] Update bootstrap script to latest stable (2016.08.15) (saltstack#35462) [2016.3] Update bootstrap script to latest stable (2016.08.15) (saltstack#35461) Make `auth_timeout` user configurable again Fix cp.push_dir pushing empty dirs (saltstack#35442) Docker 1.12 reports tags as null (saltstack#35447) move routine call out of try/except block Minor doc fixup (saltstack#35436) Modular minion data cache. Correct errant call to argspec from master. Fix ext_job_cache. (saltstack#35427) Resolve stacktrace logged by highstate outputter if sls cannot be found (saltstack#35428) Fix opts ref, I forgot that salt-ssh state.pkg uses opts magic Only allow one sync read to happen at a time. Add to release notes, snapper! ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add support for images response when
RepoTagsentry is None{u'Created': 1471252564, u'Id': u'sha256:fffffffffffffffffffffffffffffffff', u'Labels': {}, u'ParentId': u'', u'RepoDigests': [u'repo/image@sha256:ffffffffffffffffffffffffffffffffff'], u'RepoTags': None, # <--- HERE u'Size': 281902218, u'VirtualSize': 281902218}What issues does this PR fix or reference?
#35308 #34702
Previous Behavior
Was not fixed at the right place.
New Behavior
Provide a fix, I believe to be correct.
Tests written?
Yes
Please review Salt's Contributing Guide for best practices.