Fix potential infinite loop with no error when using recursive makedirs #35849
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix an infinite loop in the file.makedirs function. If you provide a relative path with a trailing
/
(e.g. :file.makedirs mydir/
), it will result in an infinite loop since the first loop will return"mydir"
andos.path.dirname("mydir")
will return an empty string, which is not a directory that can exists.I ran into this passing a relative path to archive.extracted state, which add a / to the path if it's not present, but the behavior is the same when calling the module directly
What issues does this PR fix or reference?
Maybe #34478 ?
Previous Behavior
Infinite loop when calling
file.makedirs
with a relative path which have a trailing pathNew Behavior
Throw an error when an infinite loop is detected
Tests written?
No