for 36049, log current connected master and make status module more useful and efficient #36202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…seful and efficient
|
If anyone can help me know why the lint job is failed I will be really appreciative ;P |
skizunov
added a commit
to skizunov/salt
that referenced
this pull request
Sep 27, 2016
The following error occurs when the salt-minion runs using Python 3:
File "...\bin\lib\site-packages\salt\minion.py", line 1880,
in handle_event
elif package.startswith('__schedule_return'):
TypeError: startswith first arg must be bytes or a tuple of bytes,
not str
Use `tag` instead of `package` when reading the tag names just like
every other case.
Broken by PR saltstack#36202.
Signed-off-by: Sergey Kizunov <sergey.kizunov@ni.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is for feature request in #36049.
More than that, I change module
statusa little bit. Make a return value so that the module itself will not just be a trigger for events but return the master connection info as well.Also, refactor module
statusfor code optimization and better code efficiency.What issues does this PR fix or reference?
Previous Behavior
Detailed in #36049
New Behavior
Tests written?
No
Please review Salt's Contributing Guide for best practices.