Quote postgres privilege target names #36249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres lets you put characters in table/database names which you then must quote. So we should always quote.
|
Hi @alertedsnake. This is breaking the unit tests for postgres. Would you mind having a look? Let me know if I can help. |
|
Ooh, interesting. I tested it all ways with a live server, but didn't check
the tests. First thing in the morning, sorry about that!
|
|
@alertedsnake Many thanks! |
|
@cachedout That ought to fix the Postgres unit tests - I notice a bunch of other things fail, but nothing I touched. |
Role names can also have dashes (or others) in them, so we must also quote them.
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Sep 19, 2016
* upstream/develop: (30 commits) correct key check Create a set from the minion list Skip extra traversals of minion cache for auth Whitespace fix Add -V option to work with --versions-report Update usage docs for Thorium (saltstack#36368) Fix calc docstrings (saltstack#36366) Fix a minor typo in docs (saltstack#36365) salt/modules/apk.py: Add version() function support (saltstack#36362) postgres_extension: report changes when an extension was installed (saltstack#36335) Schema test requires jsonschema 2.5.0 or above Check for Ign/Hit membership instead of == in aptpkg.refresh_db Quote postgres privilege target names (saltstack#36249) Fixed arguments to VPC peering function (saltstack#36268) set __virtualname__ to 'service' (saltstack#36330) Use infoblox_* values if present in arguments (saltstack#36339) Return None when find_file identifies the path as a directory (saltstack#36342) remove help message from glance module (saltstack#36345) Clean up libcloud stack trace (saltstack#36314) Add resize2fs unit test from blockdev_test to disk_test (saltstack#36346) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Quotes privilege update target names and role names in salt.states.postgres_privileges.
You can put certain characters in your table/database/role names which PostgreSQL
allows but then requires you to quote. So we should always quote these.
What issues does this PR fix or reference?
None
Previous Behavior
Privilege target and role names were not quoted, this results in exceptions when you have a table, database, or role name which contains odd characters, such as a dash.
New Behavior
Quotes things which need to be quoted.
Tests written?
Unit tests have been updated.