set __virtualname__ to 'service'

[silenius]

What does this PR do?

It sets __virtualname__ to 'service'.

In the states/service.py file the check is made through the _available function:

def _available(name, ret):
    '''
    Check if the service is available
    '''
    avail = False
    if 'service.available' in __salt__:
        avail = __salt__['service.available'](name)
    elif 'service.get_all' in __salt__:
        avail = name in __salt__['service.get_all']()
    if not avail:
        ret['result'] = False
        ret['comment'] = 'The named service {0} is not available'.format(name)
    return avail

So currently it doesn't work with the daemontools module as the __virtualname__ is not service

Also: not sure if provider: daemontools is still supported as I haven't found any reference in the service state file ... and it is not mentionned in the documentation

What issues does this PR fix or reference?

None

Tests written?

No

[rallytime]

Thanks for fixing this @silenius

[PChambino]

Hi there @silenius and @rallytime ! Can you take a look at #37498 (comment)?

This PR makes salt assume that because daemontools is installed, it means that it is the system-wide init process. However, I think daemontools is more than a system-wide init process. It can be used under upstart/systemd to manage some directories of services, or to use some of its tools independently, in my case its envdir. I would say salt shouldn't default the service provider to daemontools just because it is installed. What do you think?

[silenius]

Hello, I think you are right, it should only be active when - provider: daemontools has been set in the service state. The docs for salt.modules.daemontools says that:

This module is compatible with the service states, so it can be used to maintain services using the provider argument

but I don't find any mention of provider in salt.states.service, perhaps the __virtual__ function should be fixed, currently it is:

def __virtual__():
    '''
    Only make these states available if a service provider has been detected or
    assigned for this minion
    '''
    if 'service.start' in __salt__:
        return __virtualname__
    else:
        return (False, 'No service execution module loaded: '
                'check support for service management on {0} '
                ''.format(__grains__.get('osfinger', __grains__['os']))
               )

[silenius]

Can you check if #37748 fixes the issue?

[PChambino]

Yes, it does fix the issue. I believe that is a better heuristic. 👍