-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cp.get_url: fix dest=None
behaviour with salt://
URL
#36880
Conversation
@vutny It looks like some integration tests that are related to this change are failing. Can you take a look? |
Thanks @rallytime, that was a silly typo. Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this just applies to the salt://
schema. Should we extend this to all the protocols?
@cachedout What do you mean exactly? |
I'm referring to your changes in the fileclient. It looks like they are made under the block for |
Ah! I got it. There's special I guess the only thing we could do for now is to document the status quo. I've added a note to the docstring. Is that OK? |
Meanwhile, I've added support for |
Looks good. Thanks as always, @vutny |
What does this PR do?
It makes
cp.get_url
function behave according to the docstring.What issues does this PR fix or reference?
The issue is following: the function doc says that passing
dest=None
will return file contents, but this doesn't work withsalt://
URL. See example below.Previous Behavior
New Behavior
Tests written?
Yes! Added integration tests.