Prevent source files in /tmp from being deleted by file.managed states #37023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how the ``__clean_tmp()`` function works, if you use a source file that is local to the minion but within the system's temp dir (e.g. /tmp/foo.txt), it will be removed by the file.managed state. This stops that by creating temp files with a specific prefix, and then only cleaning files that match that prefix.
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Oct 20, 2016
* upstream/develop: removed trailing whitespaces in apache_module.py Revert "Fix integration tests launching - remove redundant "config_dir" argument in call to ShellTestCase.run_run from SaltDaemonScriptBase._wait_until_running" use versionadded and deprecated warnings in apache_module Fix link in libvirt docs Clearer check. Add run_on_start to SCHEDULE_CONF (saltstack#37098) Fix issue saltstack#37063 Add one more paragraph Restructure grain writing docs [2016.3] Update salt.utils.cloud references to __utils__ for cache funcs remove options from pylint (saltstack#37054) Update the Fedora installation docs Move strip to powershell block, add -NoProfile Further clarification on new grains docs from saltstack#37028 Prevent source files in /tmp from being deleted by file.managed states (saltstack#37023) Prevent fallback to uptime on status.uptime for Solaris 9, 10 and 11. args does not always exist (saltstack#37019) Mitigates failure reports when making sure an existing supervisor process group is running, despite success.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to how the
__clean_tmp()function works, if you use a sourcefile that is local to the minion but within the system's temp dir (e.g.
/tmp/foo.txt), it will be removed by the file.managed state. This stops
that by creating temp files with a specific prefix, and then only
cleaning files that match that prefix.
Fixes #37021.
This should be merged after #37022, and then merged forward, where it will conflict in develop. See the PR message for #37022 for more information on why this approach was taken.