Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove options from pylint #37054

Merged
merged 1 commit into from
Oct 17, 2016
Merged

remove options from pylint #37054

merged 1 commit into from
Oct 17, 2016

Conversation

gtmanfred
Copy link
Contributor

@gtmanfred gtmanfred commented Oct 17, 2016

What does this PR do?

These are going to be removed in pylint 1.6, and it doesn't appear that
we are using them, and just causes extra output.

Previous behavior

Warning: option profile is obsolete and it is slated for removal in Pylint 1.6.
Warning: option comment is obsolete and it is slated for removal in Pylint 1.6.
Warning: option required-attributes is obsolete and it is slated for removal in Pylint 1.6.
Warning: option ignore-iface-methods is obsolete and it is slated for removal in Pylint 1.6.
Warning: option zope is obsolete and it is slated for removal in Pylint 1.6.

This was printed at the start of each pylint run, and causes popups in IDEs that can use pylint as a plugin

New Behavior

No more Warning messages.

@s0undt3ch can you review this and make sure I am not wrong? Thanks!

These are going to be removed in pylint 1.6, and it doesn't appear that
we are using them, and just causes extra output.
@gtmanfred gtmanfred closed this Oct 17, 2016
@gtmanfred gtmanfred reopened this Oct 17, 2016
@s0undt3ch
Copy link
Collaborator

👍

@rallytime rallytime merged commit 4eb0a89 into saltstack:2015.8 Oct 17, 2016
gitebra pushed a commit to gitebra/salt that referenced this pull request Oct 20, 2016
* upstream/develop:
  removed trailing whitespaces in apache_module.py
  Revert "Fix integration tests launching - remove redundant "config_dir" argument in call to ShellTestCase.run_run from SaltDaemonScriptBase._wait_until_running"
  use versionadded and deprecated warnings in apache_module
  Fix link in libvirt docs
  Clearer check.
  Add run_on_start to SCHEDULE_CONF (saltstack#37098)
  Fix issue saltstack#37063
  Add one more paragraph
  Restructure grain writing docs
  [2016.3] Update salt.utils.cloud references to __utils__ for cache funcs
  remove options from pylint (saltstack#37054)
  Update the Fedora installation docs
  Move strip to powershell block, add -NoProfile
  Further clarification on new grains docs from saltstack#37028
  Prevent source files in /tmp from being deleted by file.managed states (saltstack#37023)
  Prevent fallback to uptime on status.uptime for Solaris 9, 10 and 11.
  args does not always exist (saltstack#37019)
  Mitigates failure reports when making sure an existing supervisor process group is running, despite success.
@gtmanfred gtmanfred deleted the 2015.8 branch July 18, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants