Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes pkgrepo for fedora>22 #37167

Merged
merged 1 commit into from
Oct 24, 2016
Merged

Conversation

luitzifa
Copy link
Contributor

@luitzifa luitzifa commented Oct 22, 2016

What does this PR do?

This makes modules.yumpkg completely independent from yum. yum is not
installed in fedora>22, so this will actually fix pkgrepo in fedora.

What issues does this PR fix or reference?

#31240

Previous Behavior

pkgrepo failed with Failed to examine repo 'dockeriorepo': No suitable yum config file found in ('/etc/yum/yum.conf', '/etc/yum.conf')

New Behavior

pkgrepo works

Tests written?

No

This makes modules.yumpkg complete independend from yum. yum is not
installed in fedora>22, so this will actually fix pkgrepo in fedora.
@cachedout
Copy link
Contributor

@terminalmage and @basepi Any feedback here?

@basepi
Copy link
Contributor

basepi commented Oct 24, 2016

None from me. Not familiar enough with with module or dnf.

@cachedout
Copy link
Contributor

@basepi No worries. You came up in a git blame but was likely unrelated. Thanks.

@terminalmage
Copy link
Contributor

Looks to be a solid change. Should be backported to 2015.8 as well.

@terminalmage terminalmage merged commit cf0c149 into saltstack:develop Oct 24, 2016
@terminalmage terminalmage added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Oct 24, 2016
@luitzifa luitzifa deleted the dnf-fix-yumpkg branch October 25, 2016 06:31
@rallytime rallytime added ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch. and removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch labels Oct 25, 2016
rallytime pushed a commit that referenced this pull request Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZZZ[Done]-back-ported-bf RETIRED The pull request has been back-ported to an older branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants