Switch default filter tag for ONE resources from user only to all resources #37745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ources. Add get_one_version to return version of ONE.
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Nov 22, 2016
* upstream/develop: Make assigned IPs available to bootstrap script (saltstack#37828) Fix lint errors Added some smbios equivalents for SPARC Solaris. Fire waiting_for_ssh event on boot of new instance (saltstack#37819) Boto apigateway optional stacktrace in response mapping (saltstack#37618) Vmware disconnect gh (saltstack#37809) Add thorium path to syspaths (saltstack#37767) Switch default filter tag for ONE resources from user only to all resources (saltstack#37745) 1. returner no need to check whether the jid exists for external job cache setup 2. add full_ret to return doc so that the document will be informative 3. make ttl as a config attribute because salt-minion does not have keep_jobs attribute 4. add password into config attribute 5. update the documents accordingly Allow pillar.get to retrieve fresh pillar data when saltenv passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The default filter tag for ONE images, templates, VMs, etc, was set to show only items
that were owned by a user or a user's group. This PR changes it to show all items.
This PR also adds a function
get_one_versionsince I wrote it thinking that to fix this issueI was going to have to change the filter tags based on the ONE version in use. There ended up being an easier way, but I didn't want to throw out code that might be useful.
What issues does this PR fix or reference?
No open issue currently.
Previous Behavior
Accessible templates or images that could be accessed from the web interface could not
be used with Salt-cloud because Salt-cloud would not see them.