Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential solution for #38265 #38266

Closed
wants to merge 1 commit into from

Conversation

mirceaulinic
Copy link
Contributor

What does this PR do?

Inject __utils__ object into proxy module.

What issues does this PR fix or reference?

#38265

@mirceaulinic
Copy link
Contributor Author

Mmm... I'm afraid this is much over my level of understanding:

2016-12-15 08:55:00,811 [salt.loader      ][CRITICAL][31483] Failed to load grains defined in grain file napalm.model in function <function model at 0x7fd5fe9d7c80>, error:
Traceback (most recent call last):
  File "/state/home/mircea/salt/salt/loader.py", line 724, in grains
    ret = fun(proxy)
  File "/state/home/mircea/salt/salt/grains/napalm.py", line 143, in model
    return {'model': _get_grain(proxy, 'model')}
  File "/state/home/mircea/salt/salt/grains/napalm.py", line 76, in _get_grain
    grains = _retrieve_grains(proxy)
  File "/state/home/mircea/salt/salt/grains/napalm.py", line 67, in _retrieve_grains
    GRAINS_CACHE = proxy['napalm.grains']()
  File "/state/home/mircea/salt/salt/loader.py", line 1089, in __getitem__
    func = super(LazyLoader, self).__getitem__(item)
  File "/state/home/mircea/salt/salt/utils/lazy.py", line 98, in __getitem__
    return self._dict[key]
KeyError: 'napalm.grains'

@rallytime rallytime requested a review from cro December 16, 2016 15:37
@rallytime
Copy link
Contributor

Requested a review from @cro per this comment

@rallytime rallytime added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Dec 16, 2016
@mirceaulinic
Copy link
Contributor Author

@cro would you mind having a look and advise? Thanks!

@cachedout
Copy link
Contributor

Bump @cro

@cro
Copy link
Contributor

cro commented Jan 23, 2017

See #38829

@cro
Copy link
Contributor

cro commented Jan 25, 2017

@mirceaulinic: I'm closing this in favor of #38829

@cro cro closed this Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants