MANY dunder variable fixes for proxies + proxy keepalive from @mirceaulinic #38829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks very good @cro! I will try this branch next week. Thank you so much! |
|
@cro This has some lint errors. @mirceaulinic Shall I wait for you to test this? |
|
As this will go only in the |
|
There are a few pieces that need to be backported to 2016.11 and 2016.3.
…On Sun, Jan 22, 2017 at 2:37 PM, Mircea Ulinic ***@***.***> wrote:
As this will go only in the develop branch, I think we can wait a few
days. So @cachedout <https://github.com/cachedout> please allow me some
time to run several tests. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38829 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAFFewUWzfMGsBMbjAQbacKhy3dxgJGiks5rU8wKgaJpZM4Lodwx>
.
--
*--cro*
C. R. Oldham, Platform Engineer, SaltStack
cr@saltstack.com / 801-564-4673
|
|
@mirceaulinic Will do. Please let me know after you have had a chance to conduct your testing. |
|
Almost there https://jenkins.saltstack.com/job/PR/job/salt-pr-lint-n/7960/violations/file/salt/proxy/rest_sample.py/ :) I did not forget about this one, I'll test it tomorrow! |
|
@mirceaulinic Thanks for the update! |
|
Hello, I have tested this branch and I didn't notice anything suspicious! I was wondering if there would be any benefit of having the Thanks @cro! |
|
@cro Looks like this one needs to be rebased now. |
|
Go Go Jenkins! |
gitebra
pushed a commit
to gitebra/salt
that referenced
this pull request
Feb 2, 2017
* upstream/develop: (37 commits) MANY dunder variable fixes for proxies + proxy keepalive from @mirceaulinic (saltstack#38829) Missing colon Fixing a weird edge case when using salt syndics and targetting via pillar. Without this fix the master of masters ends up in an infinite loop since the data returned from the minions is differently structured than if a sync was not in use. correct checking of policy_class to compare with lower() version of the specified string (saltstack#39084) Backport saltstack#38779 to 2016.11 (saltstack#39089) update adml text search to use 'starts-with' as some policies text has trailing spaces (saltstack#39090) correctly handle scenario when "storeAsText" is True on a decimal/longDecimal element object (saltstack#39088) use the pillar kwarg explicitely add ability to override pillar data during state.sls_id run. [Bugfix] Fix state x509.crl_managed Check if data['return'] is dict type add debug logging for batch vars Don't fail test if data is empty Account for trimmed value in 'salt -d' output Run test_valid_docs in batches Update primary bonding option in rh_ip.py (saltstack#39069) Update primary bonding option in debian_ip.py (saltstack#39068) Add a bunch of missing doc module references Move fileclient tests to tests/integration/fileserver/fileclient_test.py (saltstack#39081) _in_range_inclusive class method incorrectly called isinstance ...
mirceaulinic
added a commit
to napalm-automation/napalm-salt
that referenced
this pull request
Feb 13, 2017
As a backport fro the proxy keepalive feature from the Nitrogen release, introduced in saltstack/salt#38829 Till Nitrogen will be public available, this module can be scheduled and it will keep the connection always alive.
This was referenced Feb 13, 2017
mirceaulinic
added a commit
to cloudflare/salt
that referenced
this pull request
Mar 31, 2017
Although added by @cro in saltstack#38829 - see https://github.com/saltstack/salt/pull/38829/files#diff-b5732eecf0273ccf6a96e1c720198dc6 for very obscure reasons, these changes somehow disappeared. Readding them, hopefully they'll resist longer this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes numerous situations where
__proxy__and other dunder variables should have been available. In addition, adds the proxy_alive functionality contributed by @mirceaulinic. Documentation coming in next PR.What issues does this PR fix or reference?
#38753 #38557 #38265 #32918
Supersedes PR: #38265 #37864
@alexbleotu @mirceaulinic I will go back and look at 2016.3 to see which of these should be backported to fix the similar issues there.
Tests written?
Not yet, but soon!