Fix eauth error with openLDAP/389 directory server groups #38406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36148
What does this PR do?
Enable external (ldap) authorization based on users and groups.
What issues does this PR fix or reference?
#36148
Previous Behavior
It seems that the current tests for external user/group permissions fail to check groups, if permissions are set for groups only and no users are mentioned in the config file, users of that group won't be able to run commands.
New Behavior
There is already a test that checks for groups and users in master.py, after removing the test that checks user permissions it is possible to use groups.
Tests written?
No
Please review Salt's Contributing Guide for best practices.