Backport of #42270 #42290
Merged
Backport of #42270 #42290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 13, 2017 10:10
|
@isbm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terminalmage, @mirceaulinic and @rallytime to be potential reviewers. |
|
@cachedout I mean... yeah, I got your note about the release. But still just in case you guys change your mind and are OK to include the bugfix that has been found in RC1 and so want it having in the final release... — I've made it convenient for you. Tests written/fixed. But I think this still belongs here, even as a patch on top of the release. |
|
@isbm Thank you for back-porting this. While it won't make it into the 2017.7.0 release as @cachedout stated in your other PR, we do want this fix on the 2017.7 branch. |
cachedout
approved these changes
Jul 27, 2017
terminalmage
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Just backports #42276 and fixes @cachedout 's notes.
Tests written?
Yes