Isbm module run parambug 42270 #42276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 12, 2017 17:12
|
@isbm, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terminalmage, @mirceaulinic and @rallytime to be potential reviewers. |
|
@cachedout I think this is needed to go to the 2017.7 before the release... |
|
@isbm It won't make it into the release, sorry. |
cachedout
reviewed
Jul 12, 2017
doc/topics/releases/2017.7.0.rst
Outdated
| Since a lot of users are already using :py:func:`module.run | ||
| <salt.states.module.run>` states, this new behavior must currently be | ||
| explicitly turned on, to allow users to take their time updating their SLS | ||
| files. However, please keep in mind that the new syntax will take effect in | ||
| the next feature release of Salt (Oxygen) and the old usage will no longer be | ||
| supported at that time. | ||
|
|
||
| Another feature of the new :py:func:`module.run <salt.states.module.run>` is that | ||
| it allows to call many functions in a single batch, such as: |
There was a problem hiding this comment.
it allows calling many functions...
doc/topics/releases/2017.7.0.rst
Outdated
| - myparam | ||
| - my_other_param | ||
|
|
||
| In a rare case you have a function that needs to be called several times but |
There was a problem hiding this comment.
In the rare case that you have...
doc/topics/releases/2017.7.0.rst
Outdated
|
|
||
| In a rare case you have a function that needs to be called several times but | ||
| with the different parameters, an additional feature of "tagging" is to the | ||
| rescue. In order to tag a function, use a colon delimeter. For example |
Merged
|
@cachedout all these pytests aren't really related to this particular PR, right? Or I am missing something? |
|
Most of these have been fixed upstream, but I can update this branch just to be sure we don't miss anything. Thanks @isbm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the issue on
module.run: #42270Fixes the documentation for
module.run. Allows running the same function within the same functionset with the different parameters. Fixes tests.Note: probably needs to be backported to 2017.7
Tests written?
Yes