pillar.items pillar_env & pillar_override are never used #42388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a few bugs in pillar_env determination and pillar_enc decryption
|
@The-Loeki, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cachedout, @terminalmage and @lorengordon to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs in pillar_env determination and pillar_enc decryption because the
pillarenvandpillar_overrideare set with new behaviours and subsequently ignored.What issues does this PR fix or reference?
Previous Behavior
Function ignores
pillarenvandpillar_override; both might be different/broken from what's done depending on various conditionsNew Behavior
Take the newly parsed vars
Please review Salt's Contributing Guide for best practices.