Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import util modules on Master like it works on Minion #43129

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Import util modules on Master like it works on Minion #43129

merged 1 commit into from
Aug 23, 2017

Conversation

vutny
Copy link
Contributor

@vutny vutny commented Aug 23, 2017

What does this PR do?

The main purpose of this PR is to allow instantiating objects from classes declared in util modules to work with Master side modules, such as Runners, Outputters, etc, like it already possible to do in Minion modules.
Also, it introduces utils_dirs configuration option to add any directories as a source of utility modules without the need to follow a structure enforced by extension_modules or module_dirs.

Previous Behavior

It was not possible to develop Master side module, which directly imports utils Python modules.

New Behavior

All configured utils directories will be added to the system paths, so util modules become importable.

Tests written?

No.

@ghost
Copy link

ghost commented Aug 23, 2017

@vutny, thanks for your PR! By analyzing the history of the files in this pull request, we identified @honzakral, @thatch45 and @msteed to be potential reviewers.

@cachedout cachedout merged commit 3083ac3 into saltstack:develop Aug 23, 2017
@vutny vutny deleted the import-master-util-modules branch March 23, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants