Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2017.7] Fixes to scheduler __pub values in kwargs #43443

Merged

Conversation

garethgreenaway
Copy link
Contributor

Adding a small check to ensure we do not continue to populate kwargs with _pub items from the kwargs item.

What does this PR do?

Causes the scheduler to ignore the kwargs argument when creating the __pub values inside kwargs, otherwise we end with an ever growing dict of nested __pub values.

What issues does this PR fix or reference?

#43386

Tests written?

No

Please review Salt's Contributing Guide for best practices.

@ghost
Copy link

ghost commented Sep 11, 2017

@garethgreenaway, thanks for your PR! By analyzing the history of the files in this pull request, we identified @isbm, @vutny and @thatch45 to be potential reviewers.

@cachedout
Copy link
Contributor

Go Go Jenkins!

@rallytime
Copy link
Contributor

@garethgreenaway This is failing because you're using is when you should be using if in your conditional.

Fixing typo.
@garethgreenaway
Copy link
Contributor Author

@rallytime 👍 Thanks for catching that. Fixed in last commit.

@rallytime rallytime merged commit 2fc237a into saltstack:2017.7 Sep 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants