Add handling for FreeBSD in timezone.zone_compare #44605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en /etc/localtime file does is absent. This is valid configuration on FreeBSD and represents UTC.
cachedout
approved these changes
Nov 20, 2017
rallytime
approved these changes
Nov 20, 2017
rallytime
added
the
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds code to call out specific case when /etc/localtime is absent on FreeBSD in the zone_compare method. PR means zone_compare will not cause exception when FreeBSD is set to UTC by absent /etc/localtime link or file.
What issues does this PR fix or reference?
timezone.system fails when /etc/localtime is missing on FreeBSD #44083
#44083
Previous Behavior
method caused exception if /etc/localtime was missing on FreeBSD
New Behavior
For FreeBSD - if /etc/localtime is absent, zone_compare will use the timezone reported by the OS to determine if set_zone needs to be executed.
Tests written?
No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.