Fix TypeError during rbenv ruby installation when rbenv is not found #44900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you change this PR to be against the oldest branch that this bug is present in? Should be 2016.11 if it is present in that release. https://docs.saltstack.com/en/latest/topics/development/contributing.html#main-release-branches Thanks, |
|
This error occurs on 2017.7.2 and also on "develop" branch. I didn't test older releases. |
|
Then can you move the PR to be against the You may have to move the commit over to that branch manually. If you are not able to do that, we can back port it, but for future reference, PRs for bugs should be opened against the oldest supported release that the bug is present in. Thanks, |
|
PR updated, based on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the
TypeError: 'bool' object has no attribute '__getitem__'error during execution of rbenv.installed state. Error occurred when salt couldn't find rbenv. Now state execution finishes with "Failed to install ruby" message in that case.What issues does this PR fix or reference?
Related to #44811.
Tests written?
No
Commits signed with GPG?
No