Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmd run_all bg error #45932

Merged
merged 4 commits into from
Feb 16, 2018
Merged

Fix cmd run_all bg error #45932

merged 4 commits into from
Feb 16, 2018

Conversation

The-Loeki
Copy link
Contributor

What does this PR do?

Fix erroneous logging/retcode errors when bg=True in cmd.run(_all)

What issues does this PR fix or reference?

relates to #39980
fixes #42932

Previous Behavior

root@w1:~# salt-call -l debug --out=raw cmd.run_all bg=True 'sleep 5' 
[DEBUG   ] LazyLoaded cmd.run_all
[DEBUG   ] LazyLoaded config.get
[INFO    ] Executing command 'sleep 5' in directory '/root'. Executing command in the background, no output will be logged.
[ERROR   ] Command 'sleep 5' failed with return code: None
[DEBUG   ] LazyLoaded raw.output
{'local': {'pid': 18860, 'retcode': None, 'stderr': '', 'stdout': None}}

New Behavior

root@w1:~# salt-call -l debug --out=raw cmd.run_all bg=True 'sleep 5' 
[DEBUG   ] LazyLoaded config.get
[INFO    ] Executing command 'sleep 5' in directory '/root'. Executing command in the background, no output will be logged.
[DEBUG   ] LazyLoaded raw.output
{'local': {'pid': 17579, 'retcode': None, 'stderr': '', 'stdout': None}}

@terminalmage terminalmage added bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch ZRELEASED - 2018.3.0rc1 labels Feb 16, 2018
@rallytime rallytime merged commit 5e0e2a3 into saltstack:2017.7 Feb 16, 2018
@rallytime
Copy link
Contributor

@The-Loeki In order to get this into the oxygen RC, it needs to be submitted directly there. However, it's not cherry-picking cleanly. Can you make this fix against the oxygen.rc1 branch as well if you'd like the fix in oxygen.rc1? Thanks!

@rallytime rallytime removed bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch ZRELEASED - 2018.3.0rc1 labels Feb 16, 2018
rallytime pushed a commit that referenced this pull request Feb 28, 2018
@The-Loeki The-Loeki deleted the fix_cmd_run_all_bg branch April 12, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants