Fix respository (=> repository) typo in sls_build #46997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This typo looks to have been introduced with 64aa4fb and would affect anyone relying on the deprecated "name" attribute.
rallytime
approved these changes
Apr 10, 2018
rallytime
added
the
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This typo looks to have been introduced with 64aa4fb and would affect anyone relying on the deprecated "name" attribute.
What issues does this PR fix or reference?
Previous Behavior
The
nameattribute would not have been treated as therepositoryvalue.New Behavior
The
nameattribute now provides the value of therepositoryvalue, if present.Tests written?
Yes/No
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.