Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude opt-1/opt-2 .pyc files in loader.py #48177

Closed
wants to merge 17 commits into from

Conversation

angeloudy
Copy link
Contributor

What does this PR do?

Exclude opt-1/opt-2 pyc files

What issues does this PR fix or reference?

#47006

Previous Behavior

Ch3LL and others added 17 commits May 30, 2018 14:14
Remove In Progress for 2018.3.1 Release Notes
The __name__ attribute must be a str type, unicode types will result in
a TypeError.
salt.modules.testinframod: fix TypeError invoking types.FunctionType
Update 2018.3.1 release notes with new fixes
On FreeBSD platform, the build generates bytecode files named *opt-1.pyc/ *opt-2.pyc, which caused the issue of  saltstack#47006
@angeloudy angeloudy requested a review from a team as a code owner June 18, 2018 06:06
@ghost ghost requested review from a team June 18, 2018 06:06
@angeloudy angeloudy changed the title Patch 2 Exclude opt-1/opt-2 files in loader.py Jun 18, 2018
@angeloudy angeloudy changed the title Exclude opt-1/opt-2 files in loader.py Exclude opt-1/opt-2 .pyc files in loader.py Jun 18, 2018
@isbm
Copy link
Contributor

isbm commented Jun 18, 2018

@angeloudy conflicts, please resolve them.

Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need the extra commits removed from the PR.

@angeloudy angeloudy closed this Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants