Join GitHub today
[2017.7] fixes to states/pkg.py #48426
What does this PR do?
Fixing a situation when a package is already installed via salt or manually and a state attempts to set that package to be held.
What issues does this PR fix or reference?
Previously the holding/unholding logic was only being run against packages that were being installed.
This change moves the holding logic outside and runs it against all desired packages. Adding a new test to test holding logic.
Commits signed with GPG?
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.
@garethgreenaway Can you fix the lint here? https://jenkinsci.saltstack.com/job/pr-lint/job/PR-48426/1/warnings52Result/