Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix X509 remote signing on python3 #49508

Merged
merged 4 commits into from Sep 6, 2018
Merged

Fix X509 remote signing on python3 #49508

merged 4 commits into from Sep 6, 2018

Commits on Sep 5, 2018

  1. Use to_str salt.utils when writing to a file.

    Florian Bergmann committed Sep 5, 2018
    Copy the full SHA
    65c37a2 View commit details
    Browse the repository at this point in the history

  2. Assign the certificate as a string.

    Florian Bergmann committed Sep 5, 2018
    Copy the full SHA
    699407a View commit details
    Browse the repository at this point in the history

  3. Convert to string before sending via 'publish'. 

    Otherwise the publish call with receive a "b''" string, which can not be used
in the functions.
    Florian Bergmann committed Sep 5, 2018
    Copy the full SHA
    b172b64 View commit details
    Browse the repository at this point in the history

  4. Do not silently ignore errors. 

    At least log the occurring errors to debug and trace.
    Florian Bergmann committed Sep 5, 2018
    Copy the full SHA
    be6f577 View commit details
    Browse the repository at this point in the history