Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Optimize postgres groups management #49533

Merged
merged 2 commits into from
Sep 7, 2018

Conversation

silenius
Copy link
Contributor

@silenius silenius commented Sep 6, 2018

cherry-pick of 075e0e6 to 2018.3.3

Use single SQL query to fetch all roles. Fixes saltstack#34734 and saltstack#35070. Also
fixes issue with nologin roles being added to groups every time Salt is
run.
@rallytime
Copy link
Contributor

Hi @silenius can you move this to the 2018.3 branch? We're in the final stages of testing and hardening the 2018.3.3 release and not taking additional fixes there at this time.

@rallytime rallytime added the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Sep 6, 2018
@silenius silenius changed the base branch from 2018.3.3 to 2018.3 September 6, 2018 15:18
@silenius
Copy link
Contributor Author

silenius commented Sep 6, 2018

should be ok 😃

@rallytime rallytime removed the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Sep 6, 2018
@rallytime
Copy link
Contributor

Refs #45966

@rallytime rallytime merged commit 8b971e5 into saltstack:2018.3 Sep 7, 2018
@silenius silenius deleted the 2018.3.3 branch September 9, 2018 20:50
@silenius silenius restored the 2018.3.3 branch February 10, 2020 14:15
@silenius silenius deleted the 2018.3.3 branch February 10, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants