Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Optimize postgres groups management #49533

Merged
merged 2 commits into from Sep 7, 2018

Conversation

Projects
None yet
3 participants
@silenius
Copy link
Contributor

commented Sep 6, 2018

cherry-pick of 075e0e6 to 2018.3.3

Optimize postgres groups management
Use single SQL query to fetch all roles. Fixes #34734 and #35070. Also
fixes issue with nologin roles being added to groups every time Salt is
run.
@rallytime

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

Hi @silenius can you move this to the 2018.3 branch? We're in the final stages of testing and hardening the 2018.3.3 release and not taking additional fixes there at this time.

@silenius silenius changed the base branch from 2018.3.3 to 2018.3 Sep 6, 2018

@silenius

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2018

should be ok 😃

@rallytime

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2018

Refs #45966

@rallytime rallytime merged commit 8b971e5 into saltstack:2018.3 Sep 7, 2018

5 of 10 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
jenkins/pr/py2-windows-2016 The py2-windows-2016 job has failed
Details
jenkins/pr/py3-centos-7 The py3-centos-7 job has failed
Details
jenkins/pr/py3-ubuntu-1604 The py3-ubuntu-1604 job has failed
Details
jenkins/pr/py3-windows-2016 The py3-windows-2016 job has failed
Details
WIP ready for review
Details
jenkins/pr/docs The docs job has passed
Details
jenkins/pr/lint The lint job has passed
Details
jenkins/pr/py2-centos-7 The py2-centos-7 job has passed
Details
jenkins/pr/py2-ubuntu-1604 The py2-ubuntu-1604 job has passed
Details

@silenius silenius deleted the silenius:2018.3.3 branch Sep 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.