Fix possible issue with test_groupadd

[twangboy]

What does this PR do?

In Windows, the group.members function returns a dicts where the result key returns true if successful. On Linux it just returns True or False. The way the test was written the check would always be True even on failure because an empty Dict results in True if you're just checking with assertTrue.

What issues does this PR fix or reference?

This checks the value in result on Windows

Tests written?

Yes

Commits signed with GPG?

Yes

[cachedout]

Why did these two platforms diverge in the first place? Would it make sense to just bring them in line with each other?

[damon-atkins]

@cachedout agree they should be the same. The state expects a true or false from all platforms as its called in a middle of an if.

Normal state outputs comments, changes, general modules do not.

[damon-atkins]

if __salt__['group.add'](name, gid=gid, system=system):

However the above seems wrong. The group.add or group.* on all platforms should raise a CommandExecutionError('some error message') and the group state should trap it.

What should the standard be? i.e. more like pkg state? Windows group.add is sort of following.

[twangboy]

Now returns bool instead of dict

[rallytime]

@twangboy and @dwoz Is that change in structure something we want to do in a dot release? I think that might be better for a feature release. Thoughts?

[cachedout]

I agree with @rallytime . I think we should consider a change in the structure in a major release but not change it here.

[twangboy]

I reverted back to just the original test fix I did. I created another PR against the Fluorine branch with the fixes I had before. #50086