-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set jenkins docs job to treat any warnings as errors (develop branch) #50504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
a team
November 13, 2018 22:36
terminalmage
force-pushed
the
develop-docs
branch
from
November 14, 2018 02:41
e54b82a
to
974e289
Compare
terminalmage
force-pushed
the
develop-docs
branch
from
November 14, 2018 14:33
974e289
to
4bd0d1d
Compare
The async renaming for Python 3.7 needed to be reproduced here as well.
terminalmage
force-pushed
the
develop-docs
branch
from
November 14, 2018 15:25
f739c90
to
e1eea76
Compare
rallytime
approved these changes
Nov 14, 2018
This causes a warning and doesn't provide a tangible benefit since we have CLI examples for functions.
terminalmage
force-pushed
the
develop-docs
branch
from
November 14, 2018 16:52
5e38c9f
to
a96f5e6
Compare
These commits are already in master, so this doesn't need to be ported and can be removed from the list of PRs to port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #50500
Also, fix a bunch of build errors.