Add random sleep time to avoid overloading Windows

[twangboy]

What does this PR do?

Fixes an issue on Windows where the salt-minion restarts over and over when the key has been denied on the master. This adds a random delay between 10 and 20 seconds before the minion exits.

What issues does this PR fix or reference?

#51138

Tests written?

No

Commits signed with GPG?

Yes

[damon-atkins]

A better solution on windows is to adjust the service, rather than effect all platforms.

nssm/ssm.exe set salt-minion AppThrottle 6000  # Exits within 60 sec,  as python a bit slow to start up
nssm/ssm.exe set salt-minion AppExit Default Restart  # already the default.
nssm/ssm.exe set salt-minion AppRestartDelay 30000  # Then delay restart by 5 min, service will indicate paused

[damon-atkins]

ping @saltstack/team-core

[damon-atkins]

Sorry must of missed the notification for this discussion #51138

[scott-korin]

A better solution on windows is to adjust the service, rather than effect all platforms.

nssm/ssm.exe set salt-minion AppThrottle 6000  # Exits within 60 sec,  as python a bit slow to start up
nssm/ssm.exe set salt-minion AppExit Default Restart  # already the default.
nssm/ssm.exe set salt-minion AppRestartDelay 30000  # Then delay restart by 5 min, service will indicate paused

Is there a way to set these values when salt-minion is installed? I don't see any of these values documented anywhere. My google-fu must be very poor, because I can't find any kind of documentation on the Salt Service Manager at all.

Since these are settings for ssm, not the salt-minion itself, I assume these values aren't in minion config file?

I am just looking for a way to automate setting these during an install or update them once the service is installed. Just run the ssm command?

Are there other related parameters? Is there documentation somewhere on these?

[scott-korin]

A better solution on windows is to adjust the service, rather than effect all platforms.

nssm/ssm.exe set salt-minion AppThrottle 6000  # Exits within 60 sec,  as python a bit slow to start up
nssm/ssm.exe set salt-minion AppExit Default Restart  # already the default.
nssm/ssm.exe set salt-minion AppRestartDelay 30000  # Then delay restart by 5 min, service will indicate paused

Is there a way to set these values when salt-minion is installed? I don't see any of these values documented anywhere. My google-fu must be very poor, because I can't find any kind of documentation on the Salt Service Manager at all.

Since these are settings for ssm, not the salt-minion itself, I assume these values aren't in minion config file?

I am just looking for a way to automate setting these during an install or update them once the service is installed. Just run the ssm command?

Are there other related parameters? Is there documentation somewhere on these?

ok, so it looks like ssm is just a SaltStack branded version of https://nssm.cc/ and what it is doing is updating WIndows service settings.