modules/zpool : make it available for compatible Solaris family #5144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 19, 2013 17:22
The whole module has been reviewed for a better compliance with Salt and now Solaris (> 5.9) / SmartOS can use it. Some commands have been simplified and the idea is to provide another module for the 'zfs' command support.
| if pool_name in pool: | ||
| return True | ||
| return None | ||
| supported = ['Solaris', 'SmartOS', 'FreeBSD'] |
There was a problem hiding this comment.
This should be a set instead of a list.
thatch45
added a commit
that referenced
this pull request
May 20, 2013
modules/zpool : make it available for compatible Solaris family
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole module has been reviewed for a better compliance with Salt and now
Solaris (> 5.9) / SmartOS can use it. Some commands have been simplified and
the idea is to provide another module for the 'zfs' command support.