Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2019.2.1] skip test_issue_2594_non_invalidated_cache on MacOS #53913

Conversation

@garethgreenaway
Copy link
Member

commented Jul 18, 2019

What does this PR do?

Skip the test test_issue_2594_non_invalidated_cache on MacOS where it is flaky.

What issues does this PR fix or reference?

N/A

Tests written?

[NOTICE] Bug fixes or features added to Salt require tests.
Please review the test documentation for details on how to implement tests into Salt's test suite.
No. Test disabled.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

… is flakey.
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jul 18, 2019
@pull-assigner pull-assigner bot requested review from dwoz and removed request for saltstack/team-core Jul 18, 2019
@garethgreenaway garethgreenaway requested a review from saltstack/team-core Jul 18, 2019
@pull-assigner pull-assigner bot removed the request for review from saltstack/team-core Jul 18, 2019
@Akm0d
Akm0d approved these changes Jul 18, 2019
@dwoz

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

Merging without PR tests since they are flaky ATM

@dwoz dwoz merged commit a54ec89 into saltstack:2019.2.1 Jul 19, 2019
21 of 24 checks passed
21 of 24 checks passed
ci/py2/amazon2 This commit cannot be built
Details
ci/py2/centos7/tcp This commit cannot be built
Details
ci/py3/centos7 This commit cannot be built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7/tcp This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
ci/py3/windows2016 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.