Remove virt.pool_delete fast parameter #54475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I took a look at this PR and the area of code it touches, and I am certainly no expect but I see that you @cbosdo have quite a lot of code in this file so I will approve it. However, I will ask that you rebase and target |
xeacott
approved these changes
Oct 14, 2019
cbosdo
force-pushed
the
virt_pool_delete_fix
branch
from
1650eeb to
35bc98e
Compare
ghost
requested a review
from
cbosdo
force-pushed
the
virt_pool_delete_fix
branch
from
35bc98e to
092ee95
Compare
Contributor
Author
|
@xeacott rebased on master and added a unit tests for that function... even though it doesn't test that parameter removal |
Contributor
|
Thank you! |
cbosdo
force-pushed
the
virt_pool_delete_fix
branch
from
a0b9d54 to
e981ac1
Compare
Merged
There are two reasons to remove this parameter without deprecating it: * the meaning has been mistakenly inversed * fast=True will raise an exception for every libvirt storage backend since that flag has never been implemented in any of those. Fixes issue saltstack#54474
cbosdo
force-pushed
the
virt_pool_delete_fix
branch
from
e981ac1 to
f530047
Compare
Contributor
|
The windows tests are passing but the build failed due to some left open file handles. |
dwoz
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are two reasons to remove this parameter without deprecating it:
since that flag has never been implemented in any of those.
What issues does this PR fix or reference?
Fixes issue #54474
Previous Behavior
salt 'kvmsrv' virt.pool_delete mypoolfails with a libvirt exceptionNew Behavior
salt 'kvmsrv' virt.pool_delete mypoolactually deletes the pool is that function is supported by the libvirt storage backend.Tests written?
No, trivial function even when the fast parameter existed, even simpler now.
Commits signed with GPG?
Yes