S3 pillar cache file should be opened 'wb' on python3 #54698
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
@rklaren there are some tests in On a different note - we're planning to change our branch process, so if you could rebase your change on the |
|
Thanks! I'll have a look at both rebasing and the those tests. |
|
@rklaren This needs to be re-opened against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes the S3 pillar on python3. In python3 the file that is written to with pickle.dump needs to be opened in binary write mode. The fix should be backwards compatible to python2 AFAIK.
What issues does this PR fix or reference?
Fixes #54696
Previous Behavior
Previously fetching the pillar data would fail on python3 due to the writing of the cache throwing an exception.
New Behavior
It works.
Tests written?
No. I'd not mind giving a stab at it if someone can point me at test fixtures for EC2.
Commits signed with GPG?
Yes.