Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ip_bracket can now accept ipv6 addresses with brackets #54823

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@dhiltonp
Copy link
Contributor

dhiltonp commented Sep 30, 2019

What does this PR do?

ip_bracket is now more liberal in its input - attempting to add brackets to an IPv6 address that already has brackets is not fatal.

What issues does this PR fix or reference?

#54762

Tests written?

Yes

Commits signed with GPG?

Yes

@dhiltonp dhiltonp force-pushed the dhiltonp:maybe-bracket branch from be0c622 to c268a7f Sep 30, 2019
@dhiltonp dhiltonp requested review from cmcmarrow and removed request for cmcmarrow Sep 30, 2019
@dhiltonp dhiltonp force-pushed the dhiltonp:maybe-bracket branch from c268a7f to faa1d98 Sep 30, 2019
@waynew
waynew approved these changes Sep 30, 2019
@Akm0d
Akm0d approved these changes Sep 30, 2019
@waynew
waynew approved these changes Sep 30, 2019
@dwoz dwoz merged commit 93b1c4d into saltstack:2019.2.1 Oct 1, 2019
22 of 24 checks passed
22 of 24 checks passed
ci/py3/windows2016 The build of this commit was aborted
Details
ci/py3/centos7/tcp This commit is being built
Details
WIP Ready for review
Details
ci/docs This commit looks good
Details
ci/lint This commit looks good
Details
ci/py2/amazon2 This commit looks good
Details
ci/py2/centos6 This commit looks good
Details
ci/py2/centos7 This commit looks good
Details
ci/py2/centos7/tcp This commit looks good
Details
ci/py2/debian8 This commit looks good
Details
ci/py2/debian9 This commit looks good
Details
ci/py2/fedora29 This commit looks good
Details
ci/py2/ubuntu1604 This commit looks good
Details
ci/py2/ubuntu1604/tcp This commit looks good
Details
ci/py2/ubuntu1804 This commit looks good
Details
ci/py2/windows2016 This commit looks good
Details
ci/py3/amazon2 This commit looks good
Details
ci/py3/centos7 This commit looks good
Details
ci/py3/debian8 This commit looks good
Details
ci/py3/debian9 This commit looks good
Details
ci/py3/fedora29 This commit looks good
Details
ci/py3/ubuntu1604 This commit looks good
Details
ci/py3/ubuntu1604/tcp This commit looks good
Details
ci/py3/ubuntu1804 This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.