ip_bracket can now accept ipv6 addresses with brackets #54823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhiltonp
force-pushed
the
maybe-bracket
branch
from
be0c622
to
c268a7f
Compare
dhiltonp
force-pushed
the
maybe-bracket
branch
from
c268a7f
to
faa1d98
Compare
waynew
reviewed
Sep 30, 2019
waynew
approved these changes
Sep 30, 2019
Akm0d
approved these changes
Sep 30, 2019
waynew
approved these changes
Sep 30, 2019
garethgreenaway
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
ip_bracketis now more liberal in its input - attempting to add brackets to an IPv6 address that already has brackets is not fatal.What issues does this PR fix or reference?
#54762
Tests written?
Yes
Commits signed with GPG?
Yes